-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pebble log forwarding #332
Conversation
|
Co-authored-by: Luca Bello <36242061+lucabello@users.noreply.github.com>
Unit tests are still missing validations of the actual pebble layer due to this canonical/operator#1111 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some issues with the API and a bunch of improvements that can be made on the documentation side. Take a look and let me know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some unclarity left in the updated API.
Shouldn't we have itest that verifies this feature? For instance would be nice to have an itest that checks if you have a charm with 2 containers everything works |
Issue
Closes #333.
Solution
The solution has changed so many times, you'll probably have a better understanding by reading the documentation additions in the PR.