Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump golang.org/x/crypto from 0.24.0 to 0.26.0 #13921

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 12, 2024

Bumps golang.org/x/crypto from 0.24.0 to 0.26.0.

Commits
  • 5bcd010 go.mod: update golang.org/x dependencies
  • 3375612 ssh: add support for unpadded RSA signatures
  • bb80217 ssh: don't use dsa keys in integration tests
  • 6879722 ssh: remove go 1.21+ dependency on slices
  • e983fa2 sha3: Avo port of keccakf_amd64.s
  • 80fd972 LICENSE: update per Google Legal
  • f2bc3a6 x509roots/fallback/internal/goissue52287: delete
  • d66d9c3 x509roots/fallback: update bundle
  • 9fadb0b go.mod: update golang.org/x dependencies
  • a6a393f all: bump go.mod version and drop compatibility shims
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@simondeziel
Copy link
Member

simondeziel commented Aug 13, 2024

x/crypto/ssh requires Go 1.20+ while 5.0 requires to be buildable with Go 1.19. See golang/go#68469

@dependabot dependabot bot force-pushed the dependabot/go_modules/stable-5.0/golang.org/x/crypto-0.26.0 branch 2 times, most recently from b5bbcfc to 124e8ee Compare August 19, 2024 08:31
@tomponline
Copy link
Member

@simondeziel i think we'll probably have to bump the min version to 1.21.

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.24.0 to 0.26.0.
- [Commits](golang/crypto@v0.24.0...v0.26.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/stable-5.0/golang.org/x/crypto-0.26.0 branch from 124e8ee to ebd187f Compare August 27, 2024 08:25
@tomponline tomponline added the Blocked Waiting on an external task label Aug 27, 2024
@tomponline
Copy link
Member

Waiting on switch to go 1.21

@simondeziel
Copy link
Member

Closing in favor of #13993

Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 28, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/stable-5.0/golang.org/x/crypto-0.26.0 branch August 28, 2024 15:38
tomponline added a commit that referenced this pull request Aug 29, 2024
Since this allowed updating our Go modules, it fixes all 3 CVEs:

```
$ trivy fs --scanners vuln .
...

go.mod (gomod)

Total: 3 (UNKNOWN: 0, LOW: 1, MEDIUM: 1, HIGH: 1, CRITICAL: 0)

┌────────────────────────────┬─────────────────────┬──────────┬──────────┬───────────────────┬───────────────┬───────────────────────────────────────────────────────────┐
│          Library           │    Vulnerability    │ Severity │  Status  │ Installed Version │ Fixed Version │                           Title                           │
├────────────────────────────┼─────────────────────┼──────────┼──────────┼───────────────────┼───────────────┼───────────────────────────────────────────────────────────┤
│ github.com/gorilla/schema  │ CVE-2024-37298      │ HIGH     │ fixed    │ 1.4.0             │ 1.4.1         │ gorilla/schema: Potential memory exhaustion attack due to │
│                            │                     │          │          │                   │               │ sparse slice deserialization                              │
│                            │                     │          │          │                   │               │ https://avd.aquasec.com/nvd/cve-2024-37298                │
├────────────────────────────┼─────────────────────┼──────────┤          ├───────────────────┼───────────────┼───────────────────────────────────────────────────────────┤
│ google.golang.org/grpc     │ GHSA-xr7q-jx4m-x55m │ LOW      │          │ 1.64.0            │ 1.64.1        │ Private tokens could appear in logs if context containing │
│                            │                     │          │          │                   │               │ gRPC metadata is...                                       │
│                            │                     │          │          │                   │               │ GHSA-xr7q-jx4m-x55m         │
├────────────────────────────┼─────────────────────┼──────────┼──────────┼───────────────────┼───────────────┼───────────────────────────────────────────────────────────┤
│ gopkg.in/square/go-jose.v2 │ CVE-2024-28180      │ MEDIUM   │ affected │ 2.6.0             │               │ jose-go: improper handling of highly compressed data      │
│                            │                     │          │          │                   │               │ https://avd.aquasec.com/nvd/cve-2024-28180                │
└────────────────────────────┴─────────────────────┴──────────┴──────────┴───────────────────┴───────────────┴───────────────────────────────────────────────────────────┘
```

This PR supersedes #13921 and #13946.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 LTS Blocked Waiting on an external task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants