Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamic table MAASENG-2987 #125

Merged
merged 5 commits into from
Apr 11, 2024

Conversation

ndv99
Copy link
Collaborator

@ndv99 ndv99 commented Apr 9, 2024

Done

  • Upstreamed DynamicTable from MSM

QA steps

  • Ensure the component is displayed correctly across all breakpoints
  • Ensure the table can be scrolled independently of the window

Fixes

Fixes MAASENG-2987

Screenshots

image

@webteam-app
Copy link
Collaborator

@ndv99
Copy link
Collaborator Author

ndv99 commented Apr 9, 2024

Clicking the "show code" button for this component is not pretty, if there's any way I can make this look better please let me know!

@ndv99 ndv99 requested a review from petermakowski April 10, 2024 08:51
src/constants.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
src/lib/components/DynamicTable/DynamicTable.stories.tsx Outdated Show resolved Hide resolved
src/lib/components/DynamicTable/DynamicTable.stories.tsx Outdated Show resolved Hide resolved
@petermakowski
Copy link
Contributor

Clicking the "show code" button for this component is not pretty, if there's any way I can make this look better please let me know!

Have you tried https://storybook.js.org/docs/writing-stories/stories-for-multiple-components#using-children-as-an-arg or https://storybook.js.org/docs/writing-stories/stories-for-multiple-components#subcomponents

@ndv99 ndv99 changed the title feat: dynamic table MAASENG-2987 WIP feat: dynamic table MAASENG-2987 Apr 10, 2024
@ndv99 ndv99 marked this pull request as ready for review April 10, 2024 15:17
Copy link
Contributor

@petermakowski petermakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermakowski petermakowski merged commit 4aa8cfa into canonical:main Apr 11, 2024
5 checks passed
Copy link

🎉 This PR is included in version 1.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants