Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow custom main toolbar component and className #46

Merged
merged 1 commit into from
Dec 4, 2023
Merged

feat: allow custom main toolbar component and className #46

merged 1 commit into from
Dec 4, 2023

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Dec 1, 2023 •
edited by Jay-Topher
Loading

Done

  • feat: allow custom main toolbar component and className

#45 needs to be merged first

QA steps

  • Ensure the component is displayed correctly across all breakpoints
  • Edit MainToolbar.stories.tsx by adding the MainToolbar.Title as to h4 and custom className prop.
  • Run npm run storybook
  • Make sure the className has been added to the component and element changed.

Fixes

Fixes:

Screenshots

Notes

@petermakowski petermakowski marked this pull request as ready for review December 1, 2023 15:30
@petermakowski petermakowski force-pushed the feat-allow-custom-title-maintoolbar branch from 0ed1843 to ae06881 Compare December 4, 2023 09:01
@petermakowski petermakowski changed the title feat: allow custom main toolbar title and className feat: allow custom main toolbar component and className Dec 4, 2023
Jay-Topher
Jay-Topher approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@Jay-Topher Jay-Topher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@petermakowski petermakowski merged commit 8446004 into canonical:main Dec 4, 2023
12 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

🎉 This PR is included in version 1.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jay-Topher Jay-Topher Jay-Topher approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petermakowski @Jay-Topher