Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pagination): allow custom label #99

Merged
merged 1 commit into from
Feb 6, 2024
Merged

feat(pagination): allow custom label #99

merged 1 commit into from
Feb 6, 2024

Conversation

petermakowski
Copy link
Contributor

Done

  • allow custom label
  • allow custom className
  • make pagination props optional

QA steps

  • Ensure the component is displayed correctly across all breakpoints
  • [ ]

Fixes

Fixes:

Screenshots

Notes

@petermakowski
feat: allow custom label
370ed8b 
- allow custom className
- make pagination props optional
@petermakowski petermakowski requested a review from ndv99 February 6, 2024 09:52
ndv99
ndv99 approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermakowski petermakowski merged commit a09e36e into canonical:main Feb 6, 2024
5 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

🎉 This PR is included in version 1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndv99 ndv99 ndv99 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petermakowski @ndv99