backport: Make charm's images configurable #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orfeas-k
changed the title
Summary of changes: - Added script that retrieves image managed by charm.
* feat: get images on main canonical/bundle-kubeflow#679 Summary of changes: - Added script that produces list of container images managed by charm in this repository. Image list is a dynamic list. - Update tools/get-images.sh --------- Co-authored-by: Phoevos Kalemkeris <phoevos.kalemkeris@canonical.com>
Expose the metacontroller image in config.yaml, so that it can be set either pre or post deployment. This also ensures that the image is always pulled from the specified source and not a private registry, which the metacontroller StatefulSet doesn't have permission to access. Signed-off-by: Phoevos Kalemkeris <phoevos.kalemkeris@canonical.com>
orfeas-k
force-pushed
the
kf-2303-backport-airgap-support
branch
from
9da0a64
to
5e627c2
Compare
i-chvets
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Approved.
Tested with different metacontroller image:
$ juju deploy ./metacontroller-operator_ubuntu-20.04-amd64.charm metacontroller --config="metacontroller-image=docker.io/metacontrollerio/metacontroller:v2.1.0" --trust
Normal Scheduled 51s default-scheduler Successfully assigned test/metacontroller-charm-0 to ic-dev-laptop
Normal Pulling 51s kubelet Pulling image "docker.io/metacontrollerio/metacontroller:v2.1.0"
Normal Pulled 46s kubelet Successfully pulled image "docker.io/metacontrollerio/metacontroller:v2.1.0" in 4.829429786s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports changes from
mainbranch in order to make the charm's image configurable. This cherry-picks the following #68, #79 and #83. During cherry-picking those, the following were done:track/2.0there was already aget-images.shscript that was different from the one in the commit (kept the incoming change).track/2.0there was an extra comment inmetadata.yamland the image was hardcoded incharm.py(kept for both the incoming change). Also, I editedconfig.yamlin order to not introduce a different image than the one the charm was using.Closes #90