Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add testing on latest #145

Merged
merged 2 commits into from
Aug 20, 2024
Merged

ci: add testing on latest #145

merged 2 commits into from
Aug 20, 2024

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Aug 13, 2024

No description provided.

@Saviq Saviq requested a review from tarek-y-ismail August 13, 2024 20:49
@Saviq Saviq requested a review from a team as a code owner August 13, 2024 20:49
@Saviq Saviq force-pushed the add-edge branch 8 times, most recently from cb6a81e to 12a0637 Compare August 13, 2024 22:42
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.45%. Comparing base (1a39b71) to head (b4c5e76).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   68.45%   68.45%           
=======================================
  Files          16       16           
  Lines         875      875           
  Branches      126      126           
=======================================
  Hits          599      599           
  Misses        250      250           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Saviq Saviq force-pushed the add-edge branch 3 times, most recently from b4c5e76 to f6e2a7d Compare August 16, 2024 12:48
Comment on lines +33 to +38
- server: mir_demo_server
channel: null

- server: mir_demo_server
channel: null
ppa: mir-team/dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have mir_demo_server listed twice with and without a ppa? I assume the one without a ppa uses the stable version and the one with uses the most recent one?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, yes.

Comment on lines 49 to 51
- server: null
channel: null
mark: self
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This runs only the self tests, those marked with @pytest.mark.self. And measures coverage on them. So no server is involved - hence no channel.

@tarek-y-ismail tarek-y-ismail added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit bd457e8 Aug 20, 2024
16 of 29 checks passed
@tarek-y-ismail tarek-y-ismail deleted the add-edge branch August 20, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants