Fix ci assets #156
Merged
Fix ci assets #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
=======================================
Coverage 68.49% 68.49%
=======================================
Files 16 16
Lines 876 876
Branches 89 89
=======================================
Hits 600 600
Misses 251 251
Partials 25 25 ☔ View full report in Codecov by Sentry. |
The text rendering has changed in oracular.
Text rendering has changed on noble.
Text rendering is slightly different.
Saviq
commented
Dec 5, 2024
There was a problem hiding this comment.
Crazy how the "GTK" differs between scale 1.0 and 1.5!
Saviq
force-pushed
the
fix-ci-assets
branch
6 times, most recently
from
65bda62 to
fe018cd
Compare
Closing "any focused window" proved imprecise and resulted in problems on other variants.
hbatagelo
reviewed
Dec 6, 2024
mir-ci/mir_ci/tests/robot/suites/mir_flutter_app/mir_flutter_app.robot
Outdated
Show resolved
Hide resolved
mir-ci/mir_ci/tests/robot/suites/mir_flutter_app/mir_flutter_app.robot
Outdated
Show resolved
Hide resolved
mir-ci/mir_ci/tests/robot/suites/mir_flutter_app/mir_flutter_app.robot
Outdated
Show resolved
Hide resolved
mir-ci/mir_ci/tests/robot/suites/mir_flutter_app/mir_flutter_app.robot
Outdated
Show resolved
Hide resolved
Better as a common keyword Co-authored-by: Harlen Batagelo <harlen.batagelo@canonical.com>
hbatagelo
approved these changes
Dec 9, 2024
This is a flaky test now, getting stuck (I think) getting the screenshot from the compositor. Something to look at separately. |
Saviq
added a commit
to canonical/checkbox-mir
that referenced
this pull request
Dec 11, 2024
Fix ci assets (canonical/mir-ci#156) wayland: crop the timestamp so it fits in `uint` (canonical/mir-ci#157) deps: be verbose when installing snaps (canonical/mir-ci#155)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The neverputt failures are due to: