-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snap: migrate to base: core24
#70
Conversation
48b89b5
to
4ac4042
Compare
c3496a8
to
3f60f8a
Compare
536c2c1
to
362dad1
Compare
f5a3327
to
f874495
Compare
ae28ea4
to
c25e776
Compare
c25e776
to
03350bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consolidating the plugs & slots does avoid some repetition, but makes it less clear why each is required. That might matter if we come to clear things up. (It's a fairly balanced trade off - I can be persuaded.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consolidating the plugs & slots does avoid some repetition, but makes it less clear why each is required. That might matter if we come to clear things up. (It's a fairly balanced trade off - I can be persuaded.)
You mean rather than in "global" plugs:
? Yeah, I learned that's not to be used that way… check e.g. mir-test-tools-22-edge:
Warning: implicit plug assignment in 'login-session-control', 'opengl', and 'x11'. Plugs should be assigned to the app to which they apply, and not implicitly assigned via the global 'plugs:' stanza which is intended for configuration only.
(Reference: https://snapcraft.io/docs/snapcraft-interfaces)
Warning: implicit slot assignment in 'wayland'. Slots should be assigned to the app to which they apply, and not implicitly assigned via the global 'slots:' stanza which is intended for configuration only.
(Reference: https://snapcraft.io/docs/snapcraft-interfaces)
No, I mean shared (by anchors) across all the apps |
Ah. Well, if we could stick to global plugs like we had them, yeah - but because that's not The Way™, the only other option is enumerating them all… and yes, on the one hand we only had e.g. |
c84d214
to
a0ce722
Compare
Snapcraft doesn't like implicits.
Until it fixes complex grammar in stable.
@AlanGriffiths this can land now, ARM builds will fail until canonical/snapcraft#4786 makes its way into stable. |
@@ -31,6 +31,7 @@ jobs: | |||
with: | |||
architecture: ${{ matrix.platform }} | |||
snapcraft-token: ${{ secrets.SNAPCRAFT_TOKEN }} | |||
snapcraft-channel: edge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for a couple of days ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for a couple of days ;)
OK then
No description provided.