Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle mir_flutter_app into mir-test-tools snap #76

Merged
merged 2 commits into from
May 3, 2024

Conversation

hbatagelo
Copy link
Contributor

Adds mir-flutter-app built from source into the snap. When the client is executed, it is kept alive for 120 seconds. This is enough for mir-ci to run the automated integration tests using the Robot framework.

NB: The reference application needs support for the mir_shell extension. This is currently not available in the mir_demo_server from the release ppa.

@mattkae
Copy link
Contributor

mattkae commented May 1, 2024

Hmm CI is broken, although it doesn't seem to be your fault, right?

@AlanGriffiths
Copy link
Contributor

Hmm CI is broken, although it doesn't seem to be your fault, right?

Yeah, the arm{hf,64} builds are failing everywhere I look

@mattkae
Copy link
Contributor

mattkae commented May 2, 2024

Hmm CI is broken, although it doesn't seem to be your fault, right?

Yeah, the arm{hf,64} builds are failing everywhere I look

Should that guard this PR from going in? Looks unrelated...

@AlanGriffiths
Copy link
Contributor

Should that guard this PR from going in? Looks unrelated...

In principle, no.

But, I think this is an "improvement" to snapcraft remote-build that prevents us computing the version and grade for the snap. Give me a couple of hours to explore the options for fixing before landing.

@AlanGriffiths
Copy link
Contributor

The underlying problem is that snapcraft remote-build is broken. That is in turn breaking our GHA for arm{hf,64}

@AlanGriffiths AlanGriffiths enabled auto-merge May 3, 2024 13:19
Copy link
Contributor

@mattkae mattkae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for me :)

@AlanGriffiths AlanGriffiths added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit 1125532 May 3, 2024
1 of 3 checks passed
@AlanGriffiths AlanGriffiths deleted the MIRENG-479/bundle-reference-app branch May 3, 2024 13:35
github-merge-queue bot pushed a commit to canonical/mir-ci that referenced this pull request Jun 3, 2024
…118)

Adds integration tests for the reference application.

This requires mir-flutter-app to be bundled into the mir-test-tools snap
([related PR](canonical/mir-test-tools#76)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants