Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-4941]: Get rid of legacy relations #442

Merged
merged 6 commits into from
Jul 29, 2024
Merged

[DPE-4941]: Get rid of legacy relations #442

merged 6 commits into from
Jul 29, 2024

Conversation

Gu1nness
Copy link
Contributor

Issue

  • We should remove the old legacy relations code

Solution

  • Remove the old legacy code.

@Gu1nness Gu1nness marked this pull request as ready for review July 29, 2024 11:52
@Gu1nness
Copy link
Contributor Author

Should be merged after #440 so internal versions are good

delgod
delgod previously approved these changes Jul 29, 2024
View reviewed changes
MiaAltieri
MiaAltieri requested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@MiaAltieri MiaAltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here Neha! One suggestion in one of my comments and a few more here.

Looks like there are still a few remaining references to legacy/obsolete, mind taking care of those?

grep -rn legacy lib/charms/mongodb/v1/mongodb_provider.py
grep -rn legacy CONTRIBUTING.md
grep -rni obsolete src/config.py

src/charm.py Outdated Show resolved Hide resolved
tests/integration/backup_tests/test_backups.py Outdated Show resolved Hide resolved
@Gu1nness Gu1nness force-pushed the DPE-4941-mongo-db-vm-get-rid-of-legacy-relations-for-6-edge branch from 3ff14eb to e4b39e1 Compare July 29, 2024 12:18
Mehdi-Bendriss
Mehdi-Bendriss previously approved these changes Jul 29, 2024
View reviewed changes
@Gu1nness Gu1nness requested a review from MiaAltieri July 29, 2024 12:29
@Gu1nness Gu1nness merged commit bee5e73 into 6/edge Jul 29, 2024
29 of 31 checks passed
@Gu1nness Gu1nness deleted the DPE-4941-mongo-db-vm-get-rid-of-legacy-relations-for-6-edge branch July 29, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mehdi-Bendriss Mehdi-Bendriss Mehdi-Bendriss approved these changes

@MiaAltieri MiaAltieri MiaAltieri approved these changes

@delgod delgod delgod left review comments

Assignees
No one assigned
Labels
Libraries: OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gu1nness @delgod @MiaAltieri @Mehdi-Bendriss