fix: include extra files with the 'dump' plugin #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the charm packing incorrectly due to a behaviour change in charmcraft 3. See: canonical/charmcraft#1782
|
Thank you so much for your PR to Charmed MongoDB @lengau . It appears that since we upgraded to new runners on this repo, the int tests in your repo are failing. Let us look into changing permissions. If this is blocking for your work, please let me know and I can make this PR separately |
|
/canonical/self-hosted-runners/run-workflows bd75297 |
Mehdi-Bendriss
approved these changes
Aug 6, 2024
|
Merging as the tests failure is due to the Github secrets not being available for PRs made through forks. |
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In Charmcraft 3, the behaviour of the
primekeyword has changed, and the warning and documentation are not clear about the change. See: canonical/charmcraft#1782Solution
Use the
dumpplugin to include extra files, priming only the files needed.