Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: relations tests #454

Merged
merged 5 commits into from
Aug 20, 2024
Merged

fix: relations tests #454

merged 5 commits into from
Aug 20, 2024

Conversation

Gu1nness
Copy link
Contributor

@Gu1nness Gu1nness commented Aug 9, 2024 •
edited
Loading

Issue

  • Some tests are still flaky
  • Libs are not up to date

Solution

  • Bump cos-agent lib
  • Fix flakiness on backup tests: reusing the same name + destroy/recreate is not really stable so use different names
  • Fix flakiness on relations test: we sometimes call the get_connection_string before the secret is created, so retry here to get it as soon as it's ready

@Gu1nness Gu1nness force-pushed the DPE-5112-mongod-b-vm-address-remaining-flakey-ci branch from 190fde9 to e149f9d Compare August 20, 2024 08:55
@Gu1nness Gu1nness marked this pull request as ready for review August 20, 2024 08:59
MiaAltieri
MiaAltieri previously approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@MiaAltieri MiaAltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you Neha 🙇‍♀️

delgod
delgod previously approved these changes Aug 20, 2024
View reviewed changes
@Gu1nness Gu1nness dismissed stale reviews from delgod and MiaAltieri via 1e93d9c August 20, 2024 11:56
@Gu1nness Gu1nness requested a review from delgod August 20, 2024 12:03
@Gu1nness Gu1nness mentioned this pull request Aug 20, 2024
Merged
@Gu1nness Gu1nness merged commit 0f1eca9 into 6/edge Aug 20, 2024
31 checks passed
@Gu1nness Gu1nness deleted the DPE-5112-mongod-b-vm-address-remaining-flakey-ci branch August 20, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mehdi-Bendriss Mehdi-Bendriss Mehdi-Bendriss approved these changes

@MiaAltieri MiaAltieri MiaAltieri approved these changes

@delgod delgod Awaiting requested review from delgod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gu1nness @delgod @MiaAltieri @Mehdi-Bendriss