Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-5235] add changes necessary for mongos-k8s ext connections #483

Merged
merged 2 commits into from
Sep 11, 2024
Merged

[DPE-5235] add changes necessary for mongos-k8s ext connections #483

merged 2 commits into from
Sep 11, 2024

Conversation

MiaAltieri
Copy link
Contributor

Issue

mongos k8s charm can have errors while retrieving hosts, due to race conditions in units

Solution

library should be flexible to handle this scenario

@MiaAltieri MiaAltieri mentioned this pull request Sep 11, 2024
Merged
Gu1nness
Gu1nness reviewed Sep 11, 2024
View reviewed changes
src/exceptions.py Outdated Show resolved Hide resolved
Gu1nness
Gu1nness reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@Gu1nness Gu1nness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment, I think the exception should be defined in the library directly :)

@MiaAltieri MiaAltieri merged commit cf68980 into 6/edge Sep 11, 2024
27 of 30 checks passed
@MiaAltieri MiaAltieri deleted the DPE-5235-error-handling-of-k8s-hosts branch September 11, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mehdi-Bendriss Mehdi-Bendriss Mehdi-Bendriss approved these changes

@Gu1nness Gu1nness Gu1nness approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiaAltieri @Gu1nness @Mehdi-Bendriss