fix: set status library is broken. #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gu1nness
force-pushed
the
fix/status-lib-code
branch
from
ff5b707
to
3749600
Compare
Fix two calls to `get_config_server_name` which are parts of the charm code but called as if they were part of the `set_status` library.
Gu1nness
force-pushed
the
fix/status-lib-code
branch
from
3749600
to
1b13452
Compare
Mehdi-Bendriss
previously approved these changes
Sep 16, 2024
Mehdi-Bendriss
previously approved these changes
Sep 16, 2024
Gu1nness
force-pushed
the
fix/status-lib-code
branch
from
67c758c
to
f3eef3c
Compare
MiaAltieri
approved these changes
Sep 16, 2024
Mehdi-Bendriss
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
get_config_server_namewhich are parts of the charm code but called as if they were part of theset_statuslibrary.Solution