fix: Do not integrate an invalid relation #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is needed to check first if the relation is valid. The reusable check works with proxy relations (so config-server can get data proxified by mongos), so we first check here that the basic relation is valid. This should be improved in the future to make it more straightforward.
Mehdi-Bendriss
previously approved these changes
Oct 14, 2024
MiaAltieri
requested changes
Oct 15, 2024
Gu1nness
force-pushed
the
fix/do-not-integrate-if-relation-not-feasible
branch
from
d21702d
to
7d0cec2
Compare
MiaAltieri
approved these changes
Oct 15, 2024
Mehdi-Bendriss
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
It is needed to check first if the relation is valid.
Solution
The reusable check works with proxy relations (so config-server can get data proxified by mongos), so we first check here that the basic relation is valid.
This should be improved in the future to make it more straightforward.