Update data-platform-workflows to v23.0.4 and remove tox build wrapper #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tox build wrapper support removed in dpw 22: https://github.com/canonical/data-platform-workflows/releases/tag/v22.0.0 Unblocks https://warthogs.atlassian.net/browse/DPE-5809
Comment on lines
+16
to
+20
| # Workaround to add unique identifier (git hash) to charm version while specification | ||
| # DA053 - Charm versioning | ||
| # (https://docs.google.com/document/d/1Jv1jhWLl8ejK3iJn7Q3VbCIM9GIhp8926bgXpdtx-Sg/edit?pli=1) | ||
| # is pending review. | ||
| python3 -c 'import pathlib; import shutil; import subprocess; git_hash=subprocess.run(["git", "describe", "--always", "--dirty"], capture_output=True, check=True, encoding="utf-8").stdout; file = pathlib.Path("charm_version"); shutil.copy(file, pathlib.Path("charm_version.backup")); version = file.read_text().strip(); file.write_text(f"{version}+{git_hash}")' |
There was a problem hiding this comment.
is this desired? (I expect that it is since you're using upgrade v2)
but this does not match the current behavior of the build-wrapper in tox.ini
There was a problem hiding this comment.
additional context: https://chat.canonical.com/canonical/pl/xznps6x1m386mgz17r81copaty
carlcsaposs-canonical
added a commit
that referenced
this pull request
Nov 8, 2024
Unblock charmcraftcache refactor to per-charm repository caches (https://warthogs.atlassian.net/browse/DPE-5809) while #513 is pending review
carlcsaposs-canonical
added a commit
that referenced
this pull request
Nov 11, 2024
Unblock charmcraftcache refactor to per-charm repository caches (https://warthogs.atlassian.net/browse/DPE-5809) while #513 is pending review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tox build wrapper support removed in dpw 22: https://github.com/canonical/data-platform-workflows/releases/tag/v22.0.0
Unblocks https://warthogs.atlassian.net/browse/DPE-5809