Add NRPE checks #10
Merged
Add NRPE checks #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a separate library for the NRPE client which is influenced by the charmhelpers nrpe client. Only a basic TCP check is performed at the moment to ensure nats is up and running
morphis
reviewed
Sep 8, 2020
| """Publish check data on the monitors relation""" | ||
| rel = self.framework.model.get_relation(self._relation_name) | ||
| rel_data = rel.data[self.model.unit] | ||
| rel_data['version'] = '0.3' |
There was a problem hiding this comment.
What does the version mean? Is it just static or do we have to take it from somewhere?
There was a problem hiding this comment.
This is the version spec. It's not really used but doesn't hurt to specify
see https://git.launchpad.net/charm-nrpe/tree/README.md#n120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a separate library for the NRPE client which is influenced by the charmhelpers nrpe client.
Only a basic TCP check is performed at the moment to ensure nats is up and running