charm: open port NATS is listening on #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morphis
force-pushed
the
open-close-ports
branch
4 times, most recently
from
abfcbc0 to
0312523
Compare
aguadoenzo
suggested changes
Oct 26, 2020
src/charm.py
Outdated
| self.client.expose_nats(auth_token=self.state.auth_token) | ||
|
|
||
| port = '{}/tcp'.format(self.model.config['client-port']) |
There was a problem hiding this comment.
Doesn't this risk an Exception if client-port is unset in the configuration ?
There was a problem hiding this comment.
It should be always set, shouldn't it?
There was a problem hiding this comment.
I'm not 100% sure how the operator framework handles this, but what would be the behavior if we run juju config nats client-port= ? Also we should probably check that the port is a valid one before trying to open some nonsense port like None/tcp or the likes
There was a problem hiding this comment.
A juju config client-port= should still not remove the config key from the map. Checking for an empty string or a none value is indeed something we should do.
morphis
force-pushed
the
open-close-ports
branch
from
0312523 to
f35c410
Compare
The operator framework currently doesn't not support opening or closing ports the charm exposes. Due to this we have to manually invoke the open-port and close-port hook tools. The implementation also keeps track of changing ports.
morphis
force-pushed
the
open-close-ports
branch
from
f35c410 to
f531fec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator framework currently doesn't not support opening or closing
ports the charm exposes. Due to this we have to manually invoke the
open-port and close-port hook tools. The implementation also keeps track
of changing ports.