Add integration tests #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with a token This commit adds a simple integration test which checks the health of nats and whether it was configured with token or not.
jat-canonical
force-pushed
the
master
branch
2 times, most recently
from
6c8468b to
bea5491
Compare
This commit adds integration tests to NATS operator. These tests cover the following cases: 1. Standard connection to NATS with token 2. TLS Connection to NATS 3. Clustering Enabled on NATS
This commit refactors the charm to replace `snap` command calls with the corresponding charm libraries.
morphis
requested changes
Oct 12, 2023
ajanon
reviewed
Oct 13, 2023
tests/integration/relation_tests/application-charm/src/charm.py
Outdated
Show resolved
Hide resolved
jat-canonical
force-pushed
the
master
branch
3 times, most recently
from
2b44f86 to
8517925
Compare
…ation concerns This commit refactors snap interactions with the system using a snap charm library. A new class has been introduced responsible for handling interactions with NATS on the system be it via snap or directly changing the configuration for NATS.
jat-canonical
force-pushed
the
master
branch
2 times, most recently
from
c20d234 to
5bf1da0
Compare
…files This commit refactors the charm to split our relations into their own files. This commit simplifies the `recofigure_nats` function to only configure nats and split out the other tasks to their respective event hooks.
…nection url This commit adds support for juju secrets to share the protcted nats url containing the auth_token. The older way of sharing the url through relation data still remains and is available to maintain backwards compatibility. However we should depracate this when juju 3.0 becomes the de-facto standard for all the charms.
ajanon
requested changes
Oct 18, 2023
This commit adds the check that Canonical CLA be signed by every author for all raised pr to the main branch.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.