Update docs for contacts.yaml #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhijie-yang
changed the title
clay-lake
requested changes
Nov 14, 2024
tools/cli-client/README.md
Outdated
| permissions to trigger the build, upload and release of your rocks. This token should never be shared with | ||
| third-parties, nor put anywhere that is publicly available. | ||
| Upon finishing the onboarding, the user should add their GitHub username to the `rockcraft.yaml` file in the | ||
| `maintainers` field of the corresponding rock. This field is a list of GitHub usernames that are allowed to |
There was a problem hiding this comment.
Should we add a reference to the README.md with the sample contacts.yaml?
Co-authored-by: Adrian Clay Lake <clay.lake@canonical.com>
clay-lake
approved these changes
Nov 14, 2024
clay-lake
approved these changes
Nov 14, 2024
cjdcordeiro
approved these changes
Nov 18, 2024
Co-authored-by: Cristovao Cordeiro <cristovao.cordeiro@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping the @canonical/rocks team.
Description
This PR adds the descriptions of the
maintainersfield in thecontacts.yamlfile and corresponding onboarding instructions for adding the maintainers.Picture of a cool rock: