Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image name collision in Swift #319

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Fix image name collision in Swift #319

merged 3 commits into from
Dec 19, 2024

Conversation

clay-lake
Copy link
Contributor

Ping the @canonical/rocks team.

This PR fixes the recent bug in OCI-Factory where incorrect revision data was selected causing an error. Previously the start of the image name was selected, creating collisions between images like grafana and grafana-agent. This PR ensure the full image name is matched.

@clay-lake clay-lake requested a review from a team as a code owner December 19, 2024 10:56
Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the changes!

@clay-lake clay-lake merged commit cd319a3 into main Dec 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants