Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Block Release of EOL Images #320

Merged
merged 30 commits into from
Dec 20, 2024
Merged

Fix: Block Release of EOL Images #320

merged 30 commits into from
Dec 20, 2024

Conversation

clay-lake
Copy link
Contributor

@clay-lake clay-lake commented Dec 20, 2024 •
edited
Loading

This PR introduces the following changes:

  • Block release of tags specified in "release" field of image trigger which are EOL or point to EOL images.
  • Block GitHub releases of EOL tags.
  • Unit testing for new EOL behavior.
  • New EOL releases tags in mock rock image trigger (eol-release, eol-upload, and eol-both) to test behavior.

clay-lake and others added 25 commits December 19, 2024 11:06
@clay-lake
feat: eol release
ac06273
ci: automatically update oci/mock-rock/_releases.json, from https://g…
c16721e 
…ithub.com/canonical/oci-factory/actions/runs/12413194894
@clay-lake
test: end of life release
af27741
@clay-lake
Merge branch 'fix_release_of_eol_images' of https://github.com/canoni…
2d1ca73 
…cal/oci-factory into fix_release_of_eol_images
@clay-lake
test: end of life release
8b2fc7f
ci: automatically update oci/mock-rock/_releases.json, from https://g…
caa284b 
…ithub.com/canonical/oci-factory/actions/runs/12414201880
@clay-lake
feat: stop eol builds from releaseing
490c112
@clay-lake
fix: incorrect location to skip release
e53f1a2
@clay-lake
fix: incorrect location to skip release
3938d49
ci: automatically update oci/mock-rock/_releases.json, from https://g…
4a8f16f 
…ithub.com/canonical/oci-factory/actions/runs/12416643042
ci: automatically update oci/mock-rock/_releases.json, from https://g…
ccb9443 
…ithub.com/canonical/oci-factory/actions/runs/12419317887
@clay-lake
add test statments
2016d0d
@clay-lake
Merge branch 'fix_release_of_eol_images' of https://github.com/canoni…
c49f2cc 
…cal/oci-factory into fix_release_of_eol_images
ci: automatically update oci/mock-rock/_releases.json, from https://g…
ff7eb40 
…ithub.com/canonical/oci-factory/actions/runs/12419685894
@clay-lake
add test statments
88d6615
ci: automatically update oci/mock-rock/_releases.json, from https://g…
1d8fe49 
…ithub.com/canonical/oci-factory/actions/runs/12419930124
@clay-lake
fix: eol tag source
76b04be
@clay-lake
Merge branch 'fix_release_of_eol_images' of https://github.com/canoni…
f74801b 
…cal/oci-factory into fix_release_of_eol_images
ci: automatically update oci/mock-rock/_releases.json, from https://g…
124f3f6 
…ithub.com/canonical/oci-factory/actions/runs/12420269808
@clay-lake
fix: incorrect location to skip release
cc37107
@clay-lake
Merge branch 'fix_release_of_eol_images' of https://github.com/canoni…
c90eaf9 
…cal/oci-factory into fix_release_of_eol_images
ci: automatically update oci/mock-rock/_releases.json, from https://g…
c736b5b 
…ithub.com/canonical/oci-factory/actions/runs/12421547298
@clay-lake
refactor: create mergeable solution
1cf9e38
@clay-lake
Merge branch 'fix_release_of_eol_images' of https://github.com/canoni…
d875dc3 
…cal/oci-factory into fix_release_of_eol_images
@clay-lake
Merge branch 'main' of https://github.com/canonical/oci-factory into …
1063f6f 
…fix_release_of_eol_images
@clay-lake clay-lake changed the title Fix release of eol images Fix: Block Release of EOL Images Dec 20, 2024
@clay-lake clay-lake marked this pull request as ready for review December 20, 2024 10:18
@clay-lake clay-lake requested a review from a team as a code owner December 20, 2024 10:18
zhijie-yang
zhijie-yang approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@zhijie-yang zhijie-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@clay-lake clay-lake merged commit 86eb77f into main Dec 20, 2024
37 checks passed
@clay-lake clay-lake deleted the fix_release_of_eol_images branch December 20, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhijie-yang zhijie-yang zhijie-yang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clay-lake @zhijie-yang