Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add new prometheus releases #58

Merged
merged 2 commits into from
Oct 9, 2023
Merged

chore: Add new prometheus releases #58

merged 2 commits into from
Oct 9, 2023

Conversation

observability-noctua-bot
Copy link
Contributor

This is an automatic PR opened by the Observability Noctua bot.

sed-i
sed-i reviewed Sep 8, 2023
View reviewed changes
oci/prometheus/image.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like CI dumped some of the tags.
Maybe a bug that surfaced because this PR doesn't increment the version?
@lucabello

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't increment the version because we updated prometheus-rock by adding a new package, not by bumping its version it should replace those tags.

The tags being dumped though is wrong, cause it should override them as well, but I'm sure it's because our CI is set to overwrite them if >, not if >=. I'll change that :)

I'll manually fix this PR so it keeps all the tags in the meanwhile, so feel free to merge it after my commit :)

@sed-i sed-i mentioned this pull request Sep 11, 2023
Merged
3 tasks
@cjdcordeiro cjdcordeiro force-pushed the main branch 10 times, most recently from 6773854 to fbad11c Compare September 12, 2023 08:19
@SamirPS
Copy link
Contributor

SamirPS commented Sep 12, 2023

This PR is ready to review or ?

@cjdcordeiro
Copy link
Collaborator

This PR is ready to review or ?

We're waiting on #58 (comment)

@sed-i sed-i mentioned this pull request Oct 6, 2023
Closed
@lucabello lucabello mentioned this pull request Oct 6, 2023
Merged
@cjdcordeiro
Copy link
Collaborator

fyi: gh seems to be experiencing issues as our jobs are getting queued indefinitely

@cjdcordeiro cjdcordeiro merged commit b429018 into canonical:main Oct 9, 2023
18 of 20 checks passed
@lucabello lucabello mentioned this pull request Oct 11, 2023
Closed
@observability-noctua-bot observability-noctua-bot deleted the update-1694205843 branch December 12, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sed-i sed-i sed-i left review comments

@lucabello lucabello lucabello approved these changes

@cjdcordeiro cjdcordeiro cjdcordeiro approved these changes

@rebornplusplus rebornplusplus Awaiting requested review from rebornplusplus

@SamirPS SamirPS Awaiting requested review from SamirPS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@observability-noctua-bot @SamirPS @cjdcordeiro @lucabello @sed-i