Update get_notices "select=all" to "users=all" #1132
Assignees
Labels
feature
New feature or request
ops-next
To be done before shipping the next version of ops
small item
Comments
benhoyt
changed the title
|
The relevant PR for pebble is: canonical/pebble#368 |
benhoyt
pushed a commit
that referenced
this issue
Mar 12, 2024
…1146) Pebble added support for notices, aggregated events that are recorded with a type and key. The `/v1/notices` API had a parameter "select=all" to show notices for all users, and the parameter name is changed to "users=all" in recent [release v1.9.0](https://github.com/canonical/pebble/releases/tag/v1.9.0). This PR is the corresponding changes to the ops framework. Related doc: [OP042 - User ID features for Pebble Notices ](https://docs.google.com/document/d/1tQwUxz-rV-NjH-UodDbSDhGcMJGfD3OSoTnBLI9aoGU/edit#heading=h.kavgppauvkj5) See here: #1132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Per discussion with @olivercalder and Gustavo, we're going to change the
select=allparameter in Pebble (and snapd) tousers=all, and we should make the same change inpebble.Client.get_notices(as well asContainer.get_notices). This is a breaking change, but it's almost certain that no one is using this yet (if anything they'll fetch the notice viaevent.noticefor a custom event), so I think we should just go ahead and make the breaking change before it's too late, rather than try to alias everything and try to have fallbacks for different Pebble versions, and so on.For reference, the spec for user-specific notices is OP042.
The text was updated successfully, but these errors were encountered: