Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: separate the real pebble tests into a separate module #1018

Merged
merged 11 commits into from
Oct 1, 2023

Conversation

tonyandrewmeyer
Copy link
Contributor

Move the tests that use a real pebble server into a separate module, to make it clearer that these are different from the other pebble tests.

Fixes #688.

@tonyandrewmeyer tonyandrewmeyer marked this pull request as ready for review September 29, 2023 03:20
.github/workflows/framework-tests.yaml Outdated Show resolved Hide resolved
test/test_real_pebble.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@benhoyt benhoyt merged commit a7b76b8 into canonical:main Oct 1, 2023
19 checks passed
@tonyandrewmeyer tonyandrewmeyer deleted the move-real-pebble-tests-688 branch October 1, 2023 21:30
@benhoyt
Copy link
Collaborator

benhoyt commented Oct 1, 2023

Small CI/test reorg -- merging without further review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move real pebble tests into their own file.
2 participants