Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add type hints to test_charm #1022

Merged
merged 3 commits into from
Oct 2, 2023
Merged

test: add type hints to test_charm #1022

merged 3 commits into from
Oct 2, 2023

Conversation

tonyandrewmeyer
Copy link
Contributor

  • Ignore types when we are testing for bad types
  • Ignore types where we're replacing a (when type checking) property
  • Sprinkle enough type hints that pyright understands what's happening

Partially addresses #1007

benhoyt
benhoyt approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@benhoyt benhoyt merged commit 31cd829 into canonical:main Oct 2, 2023
20 checks passed
@benhoyt
Copy link
Collaborator

benhoyt commented Oct 2, 2023

Minor typing additions to test files, merged without further review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhoyt benhoyt benhoyt approved these changes

Assignees
No one assigned
Labels
type hints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyandrewmeyer @benhoyt