-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JUJU-4553] Update README.md to simplify and better align with docs #1052
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! There's some nice bits in here, but also a lot where it's unclear why changes have been made, or where changes aren't all positive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with a lot of @tonyandrewmeyer's points here -- a can understand the desire to reduce the text and link it to more official places instead, but the big preformatted installation/usage example doesn't seem like an improvement.
@tmihoc I wonder if you could provide a bit more context on what we're aiming for here?
I wonder if it'd be good to brainstorm this with the 3 of us sitting together in Riga for 30-45 minutes?
f57d109
to
2e3997d
Compare
README.md
Outdated
> ✔️ `ops` is ([`available on PyPI`](https://pypi.org/project/ops/)). | ||
> | ||
> ⚠️ The latest version of `ops` requires Python 3.8 or above. | ||
> | ||
> 🥇 While charms can be written in any language, `ops` defines the latest standard. All new charms are encouraged to use it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call me a grumpy old man :-), but I don't think these particular emojis add any value. The check mark has little to do with PyPI, the warning sign isn't really a warning, and medal != standard. I think we could just make these bullet points. Suggestion (also note slight tweaks):
> ✔️ `ops` is ([`available on PyPI`](https://pypi.org/project/ops/)). | |
> | |
> ⚠️ The latest version of `ops` requires Python 3.8 or above. | |
> | |
> 🥇 While charms can be written in any language, `ops` defines the latest standard. All new charms are encouraged to use it. | |
- `ops` is [available on PyPI](https://pypi.org/project/ops/). | |
- The latest version of `ops` requires Python 3.8 or above. | |
- While charms can be written in any language, `ops` defines the latest standard. All new charms are encouraged to use Python with `ops`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll drop the emojis. I'll also try to move the third bullet in the introduction, as it seems to fit better there. (And some of the content there seems unnecessary.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to call me a grumpy old man too 😂, but I agree about the emojis - we still have the right-hand-pointing one in the table at the top. I'm not sure why that row gets/needs an emoji?
I don't feel super strongly about it (and in all seriousness, maybe I am showing my age) so if it has value then ignore this comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we still have the right-hand-pointing one in the table at the top
I wanted the table to act like a map to the Juju universe. I'm using it for the Juju and Charmcraft READMEs too. The right-hand-pointing emoji is supposed to be the "You are here" mark. PS I'm hoping some day we can replace it with a nice visual to the same effect -- ideally a visual with clickable links, just like in the table.
README.md
Outdated
... | ||
import ops.testing | ||
... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... | |
import ops.testing | |
... | |
import ops.testing | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the dots to indicate a partial quote. Happy to drop the first set though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this now, thanks! It's good to have the test example, and I think linking to the setup/cleanup works much better than inlining it.
I've left a suggestion for the charm/directory name (I would like to improve this), and a few other very minor comments (take them or leave them).
I'll also get @tonyandrewmeyer's feedback on the latest iteration.
README.md
Outdated
|
||
> See [Charm SDK | Set up your development environment automatically > Clean up](https://juju.is/docs/sdk/dev-setup#heading--automatic-set-up-an-ubuntu-charm-dev-vm-with-multipass). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment here about the link being a mouthful, and probably not needing the full tree. Suggestion:
> See [Charm SDK | Set up your development environment automatically > Clean up](https://juju.is/docs/sdk/dev-setup#heading--automatic-set-up-an-ubuntu-charm-dev-vm-with-multipass). | |
> See [Charm SDK > Clean up](https://juju.is/docs/sdk/dev-setup#heading--automatic-set-up-an-ubuntu-charm-dev-vm-with-multipass). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
README.md
Outdated
# Learn more about statuses in the SDK docs: | ||
# https://juju.is/docs/sdk/constructs#heading--statuses | ||
self.unit.status = ops.ActiveStatus() | ||
... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
I like this too, thanks! I also left a few formatting nits, +1'd the charm name, and had some take-or-leave-them minor comments. Other than the example charm name, the one thing that I feel needs to get resolved is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks for seeing this through!
Merged -- thanks @tmihoc! Not related to this PR, but linting is broken right now due to Python 3.12 deprecations. Tony is going to fix that in a follow-up PR. |
This is part of a larger initiative to update and streamline the READMEs of all the main projects associated in the Juju universe.