Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify how custom events are emitted in emit docstring #1072

Merged
merged 2 commits into from
Nov 22, 2023
Merged

docs: clarify how custom events are emitted in emit docstring #1072

merged 2 commits into from
Nov 22, 2023

Conversation

benhoyt
Copy link
Collaborator

@benhoyt benhoyt commented Nov 21, 2023

Fixes #1070

@benhoyt benhoyt mentioned this pull request Nov 21, 2023
Closed
tonyandrewmeyer
tonyandrewmeyer approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! One minor consistency suggestion.

ops/framework.py Outdated Show resolved Hide resolved
@benhoyt @tonyandrewmeyer
Update ops/framework.py
620cf7e 
Co-authored-by: Tony Meyer <tony.meyer@gmail.com>
@benhoyt benhoyt merged commit a8ba0bd into canonical:main Nov 22, 2023
19 of 20 checks passed
@benhoyt benhoyt deleted the emit-docstring branch November 22, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyandrewmeyer tonyandrewmeyer tonyandrewmeyer approved these changes

@sed-i sed-i sed-i approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve docstring for emit
3 participants
@benhoyt @tonyandrewmeyer @sed-i