-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(harness): don't error out when attempting attaching storage before begin #1150
Merged
tonyandrewmeyer
merged 9 commits into
canonical:main
from
tonyandrewmeyer:add-storage-clearer-use-1127
Mar 18, 2024
Merged
fix(harness): don't error out when attempting attaching storage before begin #1150
tonyandrewmeyer
merged 9 commits into
canonical:main
from
tonyandrewmeyer:add-storage-clearer-use-1127
Mar 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhoyt
requested changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for this. Nit and comment about test structure.
IronCore864
approved these changes
Mar 14, 2024
Great test cases, I've learned a lot :) |
benhoyt
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One minor fix to the
storage
metadata: charmcraft.yaml and metadata.yaml support amultiple.range
value in the form<n>+
- this would previously error out when we attempted to read the metadata. We now support this (as an alias for<n>-
, which is an open-ended range rather than "n or less", and have a test for it.Adds a minor clarification in the API docs when
Harness.add_storage
will emit a storage-attached event.In
begin_with_initial_hooks
, if the storage has already been attached, then don't try to attach it a second time, but do emit the storage-attached event, since that will not have been done previously.Make the
_storage_attach
method safe to call multiple times. This appears to have been the intention based on comments in the code, but, in practice, attempting to symlink the mount would fail. Now, if the symlink already exists (and has the same target) then we continue.Adds a variety of tests for Harness
add_storage
andattach_storage
behaviour.Fixes #1127