feat(Harness): add some support for user secrets #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least we should support if a config entry has a 'secret' stanza, which is supported in juju 3.4. It doesn't do all the things yet, but a rough cut.
tonyandrewmeyer
approved these changes
Mar 28, 2024
|
The linting failures are related to the docs theme work. Once the final part of that is merged in, I'll update this branch and they should be ok. |
IronCore864
approved these changes
Mar 28, 2024
IronCore864
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least we should support if a config entry has a 'secret' stanza, which is supported in juju 3.4. It doesn't do all the things yet, but a rough cut.
This allows for testing.Harness to understand config entries of type Secret. It might be arguable that the testing harness should also be validating the content of those secret keys, such that they should conform to a secret identifier. However, this at least got me past the point of getting failures just because my charm declared the type (well, and it declared the default which it really shouldn't do anyway).
See #1166