Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: tox -e docs-deps to compile requirements.txt #1172

Merged
merged 4 commits into from
Apr 3, 2024
Merged

docs: tox -e docs-deps to compile requirements.txt #1172

merged 4 commits into from
Apr 3, 2024

Conversation

IronCore864
Copy link
Contributor

Separate pip-compile into a separate env tox -e docs-deps. Now tox -e docs only does pip-sync then sphinx-build.

@IronCore864 IronCore864 marked this pull request as ready for review March 29, 2024 15:46
benhoyt
benhoyt approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, thanks!

tonyandrewmeyer
tonyandrewmeyer requested changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a sentence in HACKING.md that mentions that this exists? Other than that, looks good to me, thanks!

tonyandrewmeyer
tonyandrewmeyer approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@IronCore864 IronCore864 merged commit a80d88a into canonical:main Apr 3, 2024
28 checks passed
@IronCore864 IronCore864 deleted the docs-pip-compile-separate-cmd branch April 3, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyandrewmeyer tonyandrewmeyer tonyandrewmeyer approved these changes

@benhoyt benhoyt benhoyt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IronCore864 @tonyandrewmeyer @benhoyt