Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add release step to update pinned charm tests #1213

Merged
merged 6 commits into from
May 30, 2024
Merged

Conversation

benhoyt
Copy link
Collaborator

@benhoyt benhoyt commented May 14, 2024

We will switch to using pinned versions of the charm (latest main) for our charm tests in the GitHub Actions. This PR adds a release step to update the pinned versions, and what to do if they fail.

@dimaqq
Copy link
Contributor

dimaqq commented May 15, 2024

Like this, right? #1215

Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, two very small suggestions.

HACKING.md Outdated Show resolved Hide resolved
HACKING.md Outdated Show resolved Hide resolved
benhoyt and others added 2 commits May 16, 2024 10:56
Co-authored-by: Tony Meyer <tony.meyer@canonical.com>
Co-authored-by: Tony Meyer <tony.meyer@canonical.com>
Now that the automatic charm pin update workflow has landed, the wording of the step needs an update.
@dimaqq dimaqq requested a review from IronCore864 May 29, 2024 05:55
@dimaqq
Copy link
Contributor

dimaqq commented May 29, 2024

I've updated the wording for the "check/update charm pins" step in the release procedure.

I've decided not to include the rollback step, as I figure that newer charm version failing against pre-release ops code should probably block the release, require figuring out what happened and sorting things out manually in general.

@benhoyt benhoyt merged commit 3e35aee into main May 30, 2024
52 checks passed
@benhoyt benhoyt deleted the pinned-charm-tests branch May 30, 2024 22:13
tonyandrewmeyer added a commit to tonyandrewmeyer/operator that referenced this pull request Jun 26, 2024
We will switch to using pinned versions of the charm (latest `main`) for
our charm tests in the GitHub Actions. This PR adds a release step to
update the pinned versions, and what to do if they fail.

---------

Co-authored-by: Tony Meyer <tony.meyer@canonical.com>
Co-authored-by: Dima Tisnek <dima.tisnek@canonical.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants