Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: verify that defer() is not usable on stop,remove,secret-expired,secret-rotate #1233

Merged

Conversation

tonyandrewmeyer
Copy link
Contributor

Extends the test for not being able to defer() an action event to also cover the other events where this is the case. This was missed in #1122.

Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Copy link
Contributor

@dimaqq dimaqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good overall; I've left some ideas, though I don't know if they are tractable.

test/test_charm.py Outdated Show resolved Hide resolved
test/test_charm.py Show resolved Hide resolved
test/test_charm.py Show resolved Hide resolved
test/test_charm.py Show resolved Hide resolved
@tonyandrewmeyer tonyandrewmeyer merged commit 5582dbb into canonical:main Jun 6, 2024
26 checks passed
@tonyandrewmeyer tonyandrewmeyer deleted the test-inappropriate-defer branch June 6, 2024 07:37
tonyandrewmeyer added a commit to tonyandrewmeyer/operator that referenced this pull request Jun 26, 2024
…,secret-rotate (canonical#1233)

Extends the test for not being able to `defer()` an action event to also
cover the other events where this is the case. This was missed in canonical#1122.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants