chore: remove f-string in logging call #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhoyt
approved these changes
May 28, 2024
| 'between when the charm was initialised and when the event was emitted. ' | ||
| 'Make sure sure you store a reference to the observer.' | ||
| 'Make sure sure you store a reference to the observer.', observer_path |
There was a problem hiding this comment.
I'm surprised Ruff doesn't put observer_path on its own line.
There was a problem hiding this comment.
it would if there was a trailing comma.
or if the line was too long and had to be split.
dimaqq
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use lazy interpolation in
logging.*calls.Missed in #1227, because I didn't think to enable multi-line searching, and this logging call wraps the f-string on to the next line.