fix: use temp dir for secret data #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaqq
changed the title
|
Also tested manually by replacing ops in a running charm venv with the content of this branch. |
benhoyt
approved these changes
Jul 21, 2024
benhoyt
reviewed
Jul 21, 2024
tonyandrewmeyer
approved these changes
Jul 21, 2024
dimaqq
added a commit
to dimaqq/operator
that referenced
this pull request
Jul 22, 2024
Change the mechanism used to pass secret values from ops to hook tools from command line to files in temporary directory. Removes the 2MB total secret size limit imposed by command line length Hook tool calls juju agent which in turn reads these files, I've confirmed with the Juju team that juju agent and charm code are run as the same user.
|
Fixes CVE-2024-41129 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the mechanism used to pass secret values from ops to hook tools from command line to files in temporary directory.
Removes the 2MB total secret size limit imposed by command line length
Hook tool calls juju agent which in turn reads these files, I've confirmed with the Juju team that juju agent and charm code are run as the same user.