-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run tests on Py 3.12 and install test on Py 3.13 #1315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discussion, we're going to add 3.12 to the places it's missing, but leave 3.13 for now. When 3.13 is out, we'll add it to the pip install
block but not for running our tests.
Aside: why do test one artefact, but not the other?
Is it because Full disclosure: I believe that the packages are equivalent for install purpose, even though the content is not equivalent: 97 files in a tarball, 26 files in a zip/whl. The differences are our tests, tox.ini, setup.cfg and pyproject.toml. |
Updated Python versions per review. |
Yeah, I think that's the reason why: if we broke installing, it's hard to see how we would break wheel and not sdist or the other way around. The packaging tools could, but probably not something we do. So if there's no point checking both, then we might as well check the one that will be used when packing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Python 3.13 has reached rc1, this PR adds it to the test matrix.
Note: not using free-threaded builds at this point due to actions/setup-python#771 (not like we'd expect any difference, frankly)