fix: correct the signature of .events() #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyandrewmeyer
changed the title
|
Thanks! Curious that pyright doesn't complain about this. |
|
I think it didn't because all attributes that were accessed were coincidentally common between the two types :) |
tonyandrewmeyer
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
LGTM, thanks!
The main case seems very straightforward - the code is clearly wanting the bound event - it's even asserting on it. The error message probably works either way, but I'm +0 on this adjustment.
The framework one should indeed be working with bound events - the class has the source, the instance has the bound event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1341