Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: typo on CharmBase inheritance example #1349

Merged
merged 1 commit into from
Aug 29, 2024
Merged

docs: typo on CharmBase inheritance example #1349

merged 1 commit into from
Aug 29, 2024

Conversation

theofpa
Copy link
Contributor

@theofpa theofpa commented Aug 29, 2024

typo: the CharmBase inheritance example should be an object, not a function

@theofpa
docs: typo on CharmBase inheritance example
f805f71 
typo: the CharmBase inheritance example should be an object, not a function
tonyandrewmeyer
tonyandrewmeyer approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

benhoyt
benhoyt approved these changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tonyandrewmeyer tonyandrewmeyer merged commit 196b82f into canonical:main Aug 29, 2024
32 checks passed
@dimaqq
Copy link
Contributor

dimaqq commented Sep 3, 2024

Thank you :)

@james-garner-canonical james-garner-canonical mentioned this pull request Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyandrewmeyer tonyandrewmeyer tonyandrewmeyer approved these changes

@benhoyt benhoyt benhoyt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theofpa @dimaqq @tonyandrewmeyer @benhoyt