Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid changing os.environ in Harness #1359

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ops/testing.py
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,10 @@ def __init__(
actions: Optional[YAMLStringOrFile] = None,
config: Optional[YAMLStringOrFile] = None,
):
if 'JUJU_VERSION' not in os.environ:
os.environ['JUJU_VERSION'] = '0.0.0'
self._juju_context = _JujuContext.from_dict(os.environ)
context_environ = os.environ.copy()
if 'JUJU_VERSION' not in context_environ:
context_environ['JUJU_VERSION'] = '0.0.0'
self._juju_context = _JujuContext.from_dict(context_environ)
self._charm_cls = charm_cls
self._charm: Optional[CharmType] = None
self._charm_dir = 'no-disk-path' # this may be updated by _create_meta
Expand Down
Loading