Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Secret.set_info and Secret.set_content can be called in the same hook #1373

Merged
merged 12 commits into from
Sep 25, 2024
Merged

fix: Secret.set_info and Secret.set_content can be called in the same hook #1373

merged 12 commits into from
Sep 25, 2024

Commits on Sep 18, 2024

  1. Fix running Secret.set_content after running Secret.set_info

    @tonyandrewmeyer
    tonyandrewmeyer committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    598ef6e View commit details
    Browse the repository at this point in the history

  2. Wrap the error when the sequencing is wrong more gracefully.

    @tonyandrewmeyer
    tonyandrewmeyer committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e9897e2 View commit details
    Browse the repository at this point in the history

  3. The unit agent is already caching the new content value, so get it fr… 

    …om there.
    @tonyandrewmeyer
    tonyandrewmeyer committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    efee3c2 View commit details
    Browse the repository at this point in the history

  4. Add tests to verify that the extra args are passed.

    @tonyandrewmeyer
    tonyandrewmeyer committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5016db6 View commit details
    Browse the repository at this point in the history

  5. Remove out-of-date doc.

    @tonyandrewmeyer
    tonyandrewmeyer committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    8f25cbf View commit details
    Browse the repository at this point in the history

  6. Reorder code as per review suggestion.

    @tonyandrewmeyer
    tonyandrewmeyer committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    fd65a4b View commit details
    Browse the repository at this point in the history

  7. Be more consistent with extend vs +=

    @tonyandrewmeyer
    tonyandrewmeyer committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3edb8d5 View commit details
    Browse the repository at this point in the history

  8. Store the cache on the Secret class.

    @tonyandrewmeyer
    tonyandrewmeyer committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    b741f06 View commit details
    Browse the repository at this point in the history

  9. Move the cache to the _ModelCache.

    @tonyandrewmeyer
    tonyandrewmeyer committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a179166 View commit details
    Browse the repository at this point in the history

  10. Update after merge.

    @tonyandrewmeyer
    tonyandrewmeyer committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d40bdfa View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Fix creating Secrets from secret events.

    @tonyandrewmeyer
    tonyandrewmeyer committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b143485 View commit details
    Browse the repository at this point in the history

  2. Add a test that verifies that set_content twice combines the content. 

    Also get rid of mock.ANY - the tests are no longer consistent with the others, but it's not worth the bother.
    @tonyandrewmeyer
    tonyandrewmeyer committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    70852a6 View commit details
    Browse the repository at this point in the history