refactor: keep the unittest.mock names in the 'mock' namespace #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhoyt
approved these changes
Sep 18, 2024
james-garner-canonical
approved these changes
Sep 18, 2024
tonyandrewmeyer
added a commit
to tonyandrewmeyer/operator
that referenced
this pull request
Oct 4, 2024
…ical#1379) No functional changes (including to the tests) - this just adjusts the imports so that the names from `unittest.mock` are imported into a `mock` namespace, rather than all into the module namespace. Primarily, this ensures that `typing.Any` and `unittest.mock.ANY` are clearly distinguished by more than case, but it's also generally tidier ("Namespaces are one honking great idea"). See discussion in canonical#1373.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes (including to the tests) - this just adjusts the imports so that the names from
unittest.mockare imported into amocknamespace, rather than all into the module namespace.Primarily, this ensures that
typing.Anyandunittest.mock.ANYare clearly distinguished by more than case, but it's also generally tidier ("Namespaces are one honking great idea").See discussion in #1373.