-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update linting with the latest ruff #1441
Merged
dimaqq
merged 4 commits into
canonical:main
from
IronCore864:refactor-after-upgrading-ruff-to-latest-version
Oct 24, 2024
Merged
refactor: update linting with the latest ruff #1441
dimaqq
merged 4 commits into
canonical:main
from
IronCore864:refactor-after-upgrading-ruff-to-latest-version
Oct 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IronCore864
changed the title
refactor: update linting with latest ruff
refactor: update linting with the latest ruff
Oct 22, 2024
dimaqq
reviewed
Oct 22, 2024
I have made some refactoring according to the reviews. Summary:
|
dimaqq
approved these changes
Oct 23, 2024
benhoyt
approved these changes
Oct 23, 2024
tonyandrewmeyer
approved these changes
Oct 23, 2024
IronCore864
deleted the
refactor-after-upgrading-ruff-to-latest-version
branch
October 24, 2024 00:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update linting rules with the latest ruff version 0.7.0.
After upgrading ruff to the latest version in this PR, some rules can be removed since they are not hitting any code, and some other rules can be relatively easily refactored.