Fixing the function signature of send_signal in _TestingPebbleClient

[weiiwang01]

This pull request addresses the issue of incorrect function signature in the send_signal method of the mocking class _TestingPebbleClient in the operator framework. Currently, the signature of send_signal method in _TestingPebbleClient does not match the send_signal method of Client in the ops.pebble module. As a result, unit tests that involve the send_signal method are failing.

Here's the function signature of send_signal in ops.testing._TestingPebbleClient right now :

operator/ops/testing.py

Line 2540 in a8717ea

def send_signal(self, sig: Union[int, str], *service_names: str):

And here's the send_signal method of ops.pebble.Client:

operator/ops/pebble.py

Line 2306 in a8717ea

def send_signal(self, sig: Union[int, str], services: Iterable[str]):

[benhoyt]

Thanks for this fix!

[benhoyt]

@weiiwang01 Out of interest, how did you notice this discrepancy?

[weiiwang01]

@weiiwang01 Out of interest, how did you notice this discrepancy?

I encountered an issue when running a unit test case that involved send_signal, an exception was raised.