Remove "dying" units from planned units #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhoyt
requested changes
May 25, 2023
There was a problem hiding this comment.
Idea looks good to me, thanks! A couple of small comments, plus I think we should add a test for this.
The current planned_units() tests only test the Harness/testing version, so perhaps we could add a couple of tests to TestModelBackend that use fake_script(self, 'goal-state', """echo '<json here>'""") to test a couple of cases:
- No units.
- Two units but none dying, and ensure it returns 2.
- Two units with one dying, and ensure it returns 1.
Co-authored-by: Ben Hoyt <benhoyt@gmail.com>
jameinel
approved these changes
May 27, 2023
jameinel
approved these changes
May 27, 2023
|
Thanks again @Mehdi-Bendriss! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue that happens during a scale-down event, where
planned_unitsincludes units with the status marked asdying.This becomes visible when say the
_storage_detachinghook errors based on certain preconditions preventing a unit from immediately disappearing.This PR essentially filters out those dying units to have an accurate count of live units.