Fix issue with relative paths in Container.push_path #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a good find, thanks! Presumably we don't have a test of this code path -- is it possible to add one? |
|
I've added another test function, that is similar to the existing one. The difference being that it's changing working directory before each tests so that the relative paths are "truly" relative :). Please let me know if further changes are required! Thank you! |
benhoyt
requested changes
Jun 14, 2023
benhoyt
approved these changes
Jun 15, 2023
benhoyt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error caused by duplicate paths in
container.push_path().Please see #948 .
QA steps
Please replace with how we can verify that the change works.
QA steps here Running `tox`Documentation changes
No changes required.
Bug reference
Fixes #948
Changelog