Avoid error in FileInfo repr due to permissions being None #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileInfo.__repr__ was raising a TypeError due to the expectation that permissions was never None, and the ":o" format string: TypeError: unsupported format string passed to NoneType.__format__ At first I was surprised that Pyright didn't catch this, because clearly dict.get can return None, but we were defining a _FileKwargs TypedDict with a non-optional "permissions" field, so fix that too. Fixes canonical#955
|
Trivial fix in testing harness, going to merge without further review. I've tested against @yanksyoon's test case in #955, but I decided not to add this as an automated test seeing we're likely getting rid of that code anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileInfo.__repr__was raising a TypeError due to the expectation that permissions was never None, and the ":o" format string:At first I was surprised that Pyright didn't catch this, because clearly dict.get can return None, but we were defining a
_FileKwargsTypedDict with a non-optional "permissions" field, so fix that too.NOTE: this code will be removed and unnecessary if OP036 is done (using the real file system for the Harness's container filesystem), but might as well fix while the iron's hot.
Fixes #955