fix(pebble): remove use of deprecated cgi module in Pebble code #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recommendation is to use the email.message.Message type. See example: https://docs.python.org/3.11/library/cgi.html#cgi.parse_header
jnsgruk
approved these changes
Aug 24, 2023
NucciTheBoss
suggested changes
Aug 24, 2023
| with self.assertRaises(pebble.ProtocolError) as cm: | ||
| self.client.pull('/etc/hosts') | ||
| self.assertIsInstance(cm.exception, pebble.Error) | ||
| self.assertEqual(str(cm.exception), | ||
| "expected Content-Type 'multipart/form-data', got 'ct'") | ||
| "expected Content-Type 'multipart/form-data', got 'c/t'") |
There was a problem hiding this comment.
Is there a reason why you needed to change this from ct to c/t?
There was a problem hiding this comment.
Yeah, the test started failing without it, because the new email.message.Message header parsing validates that the content type is of the form type/subtype.
@NucciTheBoss No kidding, feels weird to me too! It'd be much saner if it was |
benhoyt
changed the title
benhoyt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recommendation is to use the email.message.Message type. See example: https://docs.python.org/3.11/library/cgi.html#cgi.parse_header
Fixes #995