This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the ping! I did a drive-by small review while I was here :)
Co-authored-by: Tony Meyer <tony.meyer@gmail.com>
weiiwang01
force-pushed
the
secret-config
branch
from
September 25, 2024 05:10
e020fc5
to
551b26e
Compare
jdkandersson
approved these changes
Sep 25, 2024
Test coverage for 7143105
Static code analysis report
|
gregory-schiano
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Users can now provide Juju user secrets as configuration values by using the
secret
-typed configuration options. For user-defined configurations, the secret value is flattened before being passed to the application via environment variables. For instance, if a user defines a new configuration optionmy-secret
and sets its value to a Juju user secret ID containing{"foo-bar": "foobar", "bar": "bar"}
, the environment variables passed to the application will beFLASK_MY_SECRET_FOO_BAR=foobar
andFLASK_MY_SECRET_BAR=bar
.Additionally, we have introduced a new built-in configuration option for Flask, Django, Golang, and FastAPI, called
*-secret-key-id
, which replaces the older*-secret-key
configuration option. The new*-secret-key-id
option accepts a Juju secret ID containing{"value": "secret-key-..."}
. While the older*-secret-key
option is still supported, it will have lower priority compared to*-secret-key-id
.Checklist
src-docs
urgent
,trivial
,complex
)