fix: actually turn off child subreaping in reaper.Stop #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flotter
reviewed
Jul 18, 2024
internals/reaper/reaper.go
Outdated
| @@ -75,22 +73,28 @@ func Stop() error { | |||
| started = false | |||
| mutex.Unlock() | |||
|
|
|||
| err := setChildSubreaper(0) | |||
There was a problem hiding this comment.
Would it be theoretically safer to disable receiving unix.SIGCHLD signals, before we terminate the processing loop that deals with them ?
flotter
approved these changes
Jul 18, 2024
|
Yep, fair point -- fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we weren't actually turning off child subreaping at the OS level in
reaper.Stop, so it didn't reversereaper.Start. Fix this, and also simplify the error handling a little.This almost certainly didn't cause problems, because as soon as the Pebble process exits it doesn't matter. But it wouldn't have turned it off in tests, and it's just the Right Thing To Do.
Fixes #412